Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release/CI] Github flow to build polkadot/polkadot-parachain rc binaries and deb package #5963

Merged

Conversation

EgorPopelyaev
Copy link
Contributor

@EgorPopelyaev EgorPopelyaev commented Oct 8, 2024

This PR introduces a GitHub flow, that should replace a semi manual part of the release process to build rc binaries for polkadot and polkadot-parachain + the polkadot deb package.

Right now, this part of the release is done on the cleanroom machine by the release engineers via triggering bash scripts directly on the server. These GitHub flows should replace it and move everything to the CI.

The whole flow is meant to be run in the new paritytech-release where the automated release is going to be moved.

The flow includes the following steps:

  • Build polkadot, polakdot-prepare-worker, polkadot-execute-worker and polkadopt-parachain binaries
  • Sign those artefacts using gpg and generate a sha256 checksum
  • Build deb package for polakdot
  • Make a GitHub attestation
  • Upload artefacts to the S3 buckets

Closes: https://github.com/paritytech/release-engineering/issues/223

@EgorPopelyaev EgorPopelyaev added the R0-silent Changes should not be mentioned in any release notes label Oct 8, 2024
@EgorPopelyaev EgorPopelyaev requested a review from ggwpez October 8, 2024 08:19
@EgorPopelyaev EgorPopelyaev requested review from a team as code owners October 8, 2024 08:19
@paritytech-review-bot paritytech-review-bot bot requested a review from a team October 8, 2024 10:47
@alvicsam alvicsam self-requested a review October 8, 2024 11:13
.github/scripts/release/build-deb.sh Outdated Show resolved Hide resolved
PACKAGE=${2:-$BIN}

PROFILE=${PROFILE:-production}
RUST_TOOLCHAIN=stable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get this from the global CI env file? Otherwise older releases will stop building when newer rust versions come out.

Generally it is good to have all the versions fixed in files on the release branch, so that they continue to work in the future even when dependencies update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should always be the same version that we use in the CI to run tests, as only that version is guaranteed to work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think this is an old variable which is not used anywhere. Build is done in the ci-unifide container, so that rust version is matching the one we are generally using.
I'll delete it.

. "${GITHUB_WORKSPACE}"/.github/scripts/common/lib.sh

echo "Checking binary ${{ matrix.binaries }}"
check_sha256 ${{ matrix.binaries }} && echo "OK" || echo "ERR"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just ignores the error, or?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-checked it, so the function will return the error but, I guess pipeline won't fail in this case due to echo, but just show the "ERR" message. I'll delete those echoes.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team October 9, 2024 11:52
name: Release - Build node release candidate

on:
workflow_dispatch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it safe/ok that anyone in org (even accidentally) can run this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be the case, cause the setup is going so that it will be possible to trigger it only from the new paritytech-release org

@EgorPopelyaev EgorPopelyaev added this pull request to the merge queue Oct 9, 2024
Merged via the queue into paritytech:master with commit c477076 Oct 9, 2024
168 of 211 checks passed
@EgorPopelyaev EgorPopelyaev deleted the ep-add-binaries-build-pipeline branch October 9, 2024 14:32
ordian added a commit that referenced this pull request Oct 11, 2024
* master: (28 commits)
  `substrate-node`: removed excessive polkadot-sdk features (#5925)
  Rename QueueEvent::StartWork (#6015)
  [ci] Remove quick-benchmarks-omni from GitLab (#6014)
  Set larger timeout for cmd.yml (#6006)
  Fix `0003-beefy-and-mmr` test (#6003)
  Remove redundant XCMs from dry run's forwarded xcms (#5913)
  Add RadiumBlock bootnodes to Coretime Polkadot Chain spec (#5967)
  Bump strum from 0.26.2 to 0.26.3 (#5943)
  Add PVF execution priority (#4837)
  Snowbridge V2 docs (#5902)
  Fix u256 conversion in BABE (#5994)
  [ci] Move test-linux-stable-no-try-runtime to GHA (#5979)
  Bump PoV request timeout (#5924)
  [Release/CI] Github flow to build `polkadot`/`polkadot-parachain` rc binaries and deb package (#5963)
  [ci] Remove short-benchmarks from Gitlab (#5988)
  Disable flaky tests reported in 5972/5973/5974 (#5976)
  Bump some dependencies (#5886)
  bump zombienet version and set request for k8s (#5968)
  [omni-bencher] Make all runtimes work (#5872)
  Omni-Node renamings (#5915)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants