-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release/CI] Github flow to build polkadot
/polkadot-parachain
rc binaries and deb package
#5963
[Release/CI] Github flow to build polkadot
/polkadot-parachain
rc binaries and deb package
#5963
Conversation
…nto ep-add-binaries-build-pipeline
…nto ep-add-binaries-build-pipeline
PACKAGE=${2:-$BIN} | ||
|
||
PROFILE=${PROFILE:-production} | ||
RUST_TOOLCHAIN=stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get this from the global CI env file? Otherwise older releases will stop building when newer rust versions come out.
Generally it is good to have all the versions fixed in files on the release branch, so that they continue to work in the future even when dependencies update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should always be the same version that we use in the CI to run tests, as only that version is guaranteed to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I think this is an old variable which is not used anywhere. Build is done in the ci-unifide
container, so that rust version is matching the one we are generally using.
I'll delete it.
. "${GITHUB_WORKSPACE}"/.github/scripts/common/lib.sh | ||
|
||
echo "Checking binary ${{ matrix.binaries }}" | ||
check_sha256 ${{ matrix.binaries }} && echo "OK" || echo "ERR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just ignores the error, or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double-checked it, so the function will return the error but, I guess pipeline won't fail in this case due to echo
, but just show the "ERR" message. I'll delete those echoes.
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
…nto ep-add-binaries-build-pipeline
name: Release - Build node release candidate | ||
|
||
on: | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it safe/ok that anyone in org (even accidentally) can run this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be the case, cause the setup is going so that it will be possible to trigger it only from the new paritytech-release org
c477076
* master: (28 commits) `substrate-node`: removed excessive polkadot-sdk features (#5925) Rename QueueEvent::StartWork (#6015) [ci] Remove quick-benchmarks-omni from GitLab (#6014) Set larger timeout for cmd.yml (#6006) Fix `0003-beefy-and-mmr` test (#6003) Remove redundant XCMs from dry run's forwarded xcms (#5913) Add RadiumBlock bootnodes to Coretime Polkadot Chain spec (#5967) Bump strum from 0.26.2 to 0.26.3 (#5943) Add PVF execution priority (#4837) Snowbridge V2 docs (#5902) Fix u256 conversion in BABE (#5994) [ci] Move test-linux-stable-no-try-runtime to GHA (#5979) Bump PoV request timeout (#5924) [Release/CI] Github flow to build `polkadot`/`polkadot-parachain` rc binaries and deb package (#5963) [ci] Remove short-benchmarks from Gitlab (#5988) Disable flaky tests reported in 5972/5973/5974 (#5976) Bump some dependencies (#5886) bump zombienet version and set request for k8s (#5968) [omni-bencher] Make all runtimes work (#5872) Omni-Node renamings (#5915) ...
This PR introduces a GitHub flow, that should replace a semi manual part of the release process to build rc binaries for
polkadot
andpolkadot-parachain
+ thepolkadot
deb package.Right now, this part of the release is done on the
cleanroom
machine by the release engineers via triggering bash scripts directly on the server. These GitHub flows should replace it and move everything to the CI.The whole flow is meant to be run in the new paritytech-release where the automated release is going to be moved.
The flow includes the following steps:
polkadot
,polakdot-prepare-worker
,polkadot-execute-worker
andpolkadopt-parachain
binariesgpg
and generate a sha256 checksumpolakdot
Closes: https://github.com/paritytech/release-engineering/issues/223